MagiCircles / MagiCircles/SchoolIdolAPI

JP album on user profile contains non-existent cards

Open
#318 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
151
Forks
29
PR merge metrics
No merged PRs in 30d

Description

When expanding a user's Album on their page, the IDs for cards go sequentially from 1 -> 2009, where 2001 -> 2009 are the Worldwide Poster Girl Promo URs.
This is a problem because a) the WWPGPURs aren't available on JP to begin with,
and b) cards from the current latest card, (1387 as of writing) to 2000 are listed, even though the cards simply do not exist yet.

Solution: No longer display cards all the way down to 2009 on JP albums until the WWPGPURs become available, at which point don't display the non-existent cards in between

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the user-profile Album endpoint and trace how JP card IDs are selected. Compare the returned range with the latest JP card and the Worldwide Poster Girl Promo UR boundary; done means JP albums omit unavailable and non-existent cards while retaining available cards.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, python
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.