MagiCircles / MagiCircles/SchoolIdolAPI

School Idol Slots not updated when idolizing

Open
#312 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
151
Forks
29
PR merge metrics
No merged PRs in 30d

Description

I don't know if this was an oversight or if it's intended, but when idolizing a card its slots don't increment+1. For example, an unidolized SR has 2 slots, but when idolized (at least with a copy of the same card) it increases to 3. Right now, it stays at 2 slots as if you just idolized the card with a seal. I would want to assume that most cards are idolized via copies, and thus the slots should naturally increase and only be changed manually if you manually use seals.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the idolization logic and tracing how it distinguishes using a duplicate card from using a seal. Verify the current slot value for both paths, then confirm the intended copy-based increment and identify the relevant regression coverage before making changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, python
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.