MagiCircles / MagiCircles/SchoolIdolAPI

Rank ranking issue on profile page when there are multiple players of the same rank

Open
#300 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
151
Forks
29
PR merge metrics
No merged PRs in 30d

Description

When there are multiple players of the same rank before an account, the latter's rank is not calculated properly.

For example, according to the JP ranking page [http://schoolido.lu/users/?language=JP&verified=3&reverse_order=on](url), kaga should have a ranking of 15. However, this account is ranked 14 on the profile page [http://schoolido.lu/user/rinny02/#23577](url). This is cause by both elRicePan and Trombe sharing the 14th ranking.

This mismatch accumulates and becomes significant on accounts of lower ranks. For example, an JP account of rank 210 ( e.g., [http://schoolido.lu/user/pillowmagician/#60556](url) ) is ranked 80 on its profile page while it is 176 on the ranking page.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the JP ranking page with the profile pages linked in the issue, reproducing the kaga and rank-210 examples. Trace how each page calculates rank, then verify that tied players are handled consistently and the profile rank matches the ranking page for both examples.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, python
Domain
backend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.