MagiCircles / MagiCircles/SchoolIdolAPI
Non-idolized cards showing up in 'Cards you should max bond' with Idolized in wishlist
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 151
- Forks
- 29
- PR merge metrics
- No merged PRs in 30d
Description
Small issue I noticed when looking at the 'Cards you should max bond' section.
I have pet Maki (http://schoolido.lu/cards/701/) in my collection, and the idolized version in my wish list.
The max bond page will show the card. Removing the idolized from my wish list will remove the card from the filter.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the max-bond filter with pet Maki (card 701) in the collection and its idolized version in the wishlist. Trace the code that combines collection and wishlist data for “Cards you should max bond”; done when the non-idolized card is not shown for this case and removing the wishlist entry changes the result as expected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- django, python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100