MaddyUnderStars / MaddyUnderStars/shoot
Adding additional DM channel recipients
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 61
- Forks
- 5
- Avg merge
- 3d 10h
- Merged PRs (30d)
- 1
Description
There currently isn't any API route for creating DM channels with more than 1 recipient. Perhaps `POST /channels`?
some considerations:
- when you create a dm channel it first checks if you have an existing one (same code on client side as well). it does not check if *only* the specified recipient and you are in the channel, so group channels will cause this check to prevent additional 1:1 channels being made
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing DM-channel creation entry point and the client-side check for an existing channel described in the issue. Evaluate the proposed POST /channels route and the recipient-membership conditions; done means multiple recipients can create a DM channel without the existing-channel check incorrectly matching a group channel.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- express, node.js, typescript
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100