MaddyUnderStars / MaddyUnderStars/shoot
Do not expose Member IDs
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 61
- Forks
- 5
- Avg merge
- 3d 10h
- Merged PRs (30d)
- 1
Description
`Member` is just a relationship between a Role and a User, it's ID should not be given to clients as it should be completely useless
Perhaps I should remove the it's ID column entirely, since it should just be a composite key of Role.id and User.id
See #78
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the Member relationship between Role and User and read the related issue #78. Trace where Member IDs are exposed to clients and determine whether the relationship should instead use Role.id and User.id as a composite key; done means the client-facing ID is no longer exposed and the chosen data model is consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api, backend, database
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100