MaddyUnderStars / MaddyUnderStars/shoot
Guild knocking
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- TypeScript
- Stars
- 61
- Forks
- 5
- Avg merge
- 3d 10h
- Merged PRs (30d)
- 1
Description
briefly mentioned here: https://github.com/MaddyUnderStars/shoot/blob/aee988e42b8471f812655630036d187e6a29cd2f/src/util/activitypub/instanceBehaviour.ts#L11
- Guilds may be configured to accept invites manually (require 'knocking')
- When a user attempts to use a guild invite, they are instead added to the list of join requests
- This is basically just a friend request but for guilds
- Moderators of the guild can accept join requests (
MANAGE_USERSor otherwiseACCEPT_KNOCK) - Perhaps should be able to see which user accepted a join request for others
- Perhaps should be able to configure invites to bypass knocking (i.e. when a user is invited directly)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/util/activitypub/instanceBehaviour.ts at the referenced line and trace how guild invites and membership requests are handled. Clarify the knocking flow, moderator permissions, visibility of request decisions, and whether direct invites bypass it; the work is done when these behaviors are specified and implemented consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- authorization, backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100