Machine-Mavericks / Machine-Mavericks/FRC-2026

RobotContainer: toolOp.b() is double-bound to conflicting commands

Open
#38 0 comments 0 reactions 2 assignees Claimed by @zokabear View on GitHub
Dominant language
Java
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

## Bug: `toolOp.b()` bound to two conflicting commands

**File:** `src/main/java/frc/robot/RobotContainer.java` lines 182–190

```java
// Line 182
toolOp.b().onTrue(new IncrementShootersSpeed(shooter, 1.0));

// ...

// Line 190
toolOp.b().onTrue(new InstantCommand(()->shooter.shooterSpeed(58.7)));
```

`toolOp.b()` is bound to **two different commands**. In WPILib, the second `.onTrue()` binding silently overwrites the first on the same trigger. The result is that `IncrementShootersSpeed` will never fire — only the `InstantCommand` setting 58.7 RPS will.

## Fix

Decide which behavior is intended for the B button and remove the other binding. If both behaviors are needed, move one to a different button.

**Options:**
- Keep B = set speed to 58.7 RPS (direct shot command) → remove line 182
- Keep B = increment shooter speed by +1.0 → remove line 190
- Move one behavior to a free button (e.g. `toolOp.y()` is currently unused for shooter increment)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.