review reduce_by_pivots code in engine
Nobody has claimed this yet.
- Dominant language
- Macaulay2
- Stars
- 435
- Forks
- 297
- Avg merge
- 4d 20h
- Merged PRs (30d)
- 11
Description
The code (perform_reduction, reduce-pivots), in files x-mutablemat.cpp, is not being used, and appears to have been replaced by code in e/mat-elem-ops.hpp, at least for dense mutable matrices. Write tests for this code, make sure it works, and incorporate it with code that Mahrud Sayrafi has written in a branch of M2, involving local rings.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing perform_reduction and reduce-pivots in x-mutablemat.cpp with the replacement code in e/mat-elem-ops.hpp, including whether dense mutable matrices still use the older code. Review the existing tests and Mahrud Sayrafi's local-rings branch. Done means the reduction code is tested, works, and is incorporated with the local-rings changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100