Macaulay2 / Macaulay2/M2

add code to tower.{hpp,cpp} or use flint tower polynomials

Open
#611 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Engine
Dominant language
Macaulay2
Stars
435
Forks
297
Avg merge
4d 20h
Merged PRs (30d)
11

Description

Some functions in tower.cpp have not been written yet. Something sensible needs to be done with them. In particular, the lift and promote need to be written before this ring type can become generally useful. On the other hand, maybe we want to instead use flint code for such ring elements (but this needs checking into).

I have removed the following warnings from the source code, instead we are documenting this need here.
```
** compiling ../../../../../../Macaulay2/e/tower.cpp
../../../../../../Macaulay2/e/tower.cpp:136:2: warning: "write Tower::is_unit" [-W#warnings]
#warning "write Tower::is_unit"
^
../../../../../../Macaulay2/e/tower.cpp:323:2: warning: "write Tower::promote" [-W#warnings]
#warning "write Tower::promote"
^
../../../../../../Macaulay2/e/tower.cpp:335:2: warning: "write Tower::lift" [-W#warnings]
#warning "write Tower::lift"
^
../../../../../../Macaulay2/e/tower.cpp:345:2: warning: "write Tower::syzygy" [-W#warnings]
#warning "write Tower::syzygy"
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading tower.hpp and tower.cpp, focusing on the unimplemented Tower::is_unit, promote, lift, and syzygy functions. Investigate whether FLINT provides suitable tower-polynomial ring elements before choosing an implementation approach. Done means resolving that design choice and making the tower ring generally usable without the documented missing functionality.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.