Macaulay2 / Macaulay2/M2

Documentation update: Attributing the De Jong algorithm and the Grauert-Remmert-De Jong criterion

Open
#4,117 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Documentation
Dominant language
Macaulay2
Stars
435
Forks
297
Avg merge
4d 20h
Merged PRs (30d)
11

Description

Dear Dan and Mike (@dgrayson, @mstillman),

I am writing to propose a correction for the documentation of the integralClosure routines.
As the author of the 1998 paper "An algorithm for computing the integral closure", I suggest
that the documentation distinguishes more clearly between the mathematical algorithm
and its later optimizations:

Grauert-Remmert-De Jong criterion: The theoretical foundation for the Noetherian case (De Jong, 1998).

De Jong algorithm: The iterative normalization procedure.

GLS-optimization: Credit Greuel-Laplagne-Seelisch (2010) specifically for the faster computation of Hom(I,I) using fractional ideals.

Magma already correctly refers to it as the "de Jong algorithm". Harmonizing this across Macaulay2 would ensure historical and
mathematical accuracy for the community.

Best regards,
Theo de Jong

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the documentation for the integralClosure routines and review its current algorithm and attribution terminology. Update it to distinguish the Grauert-Remmert-De Jong criterion, the De Jong algorithm, and the GLS optimization, with the cited authors and dates. Done means the documentation clearly separates the mathematical algorithm from its later optimization and matches the requested historical attribution.

Written by the indexing model from the issue text.

Assessment

Domain
documentation
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.