Macaulay2 / Macaulay2/M2

LLLBases issues

Open
#3,802 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Core
Dominant language
Macaulay2
Stars
435
Forks
297
Avg merge
4d 20h
Merged PRs (30d)
11

Description

Someone should:
1. figure out what't the deal with the LLL strategy of (minimalPresentation, Module) which is disabled by `return null`?
2. figure out if the LLL strategy of resolution over ZZ is correct (see #3785)
3. document these nodes, even if just a stub:
```m2
gramm
gramm(Matrix)
LLL(...,Limit=>...)
gcdLLL(...,Strategy=>...)
kernelLLL
kernelLLL(...,Limit=>...)
kernelLLL(Matrix)
hermite
hermite(Matrix)
hermite(...,Strategy=>...)
hermite(...,ChangeMatrix=>...)
hermite(...,Limit=>...)
```
Since LLL is preloaded, on any package that uses these strategies we get a warning that these methods aren't documented.

_Originally posted by @mahrud in https://github.com/Macaulay2/M2/issues/3683#issuecomment-2715354434_

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by investigating the disabled minimalPresentation/Module LLL strategy and the resolution-over-ZZ question referenced in #3785. Then review the listed LLL, gcdLLL, kernelLLL, hermite, and gramm nodes and document them, including their Strategy, Limit, and ChangeMatrix options. Done means the strategy behavior is clarified and the preloaded package no longer warns that these methods are undocumented.

Written by the indexing model from the issue text.

Assessment

Domain
documentation
Issue type
Documentation
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.