Macaulay2 / Macaulay2/M2

genericMatrix should be row major

Open
#3,596 7 comments 0 reactions 0 assignees View on GitHub
Core
Dominant language
Macaulay2
Stars
435
Forks
297
Avg merge
4d 20h
Merged PRs (30d)
11

Description

It was pointed out during the workshop that the output of `genericMatrix` should be row major instead of column major because this makes no sense:
```m2
i1 : R = QQ[x_(1,1) .. x_(2,5)];

i2 : genericMatrix(R, 2, 5)

o2 = | x_(1,1) x_(1,3) x_(1,5) x_(2,2) x_(2,4) |
| x_(1,2) x_(1,4) x_(2,1) x_(2,3) x_(2,5) |

2 5
o2 : Matrix R <-- R
```

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue identifies the genericMatrix entry point and shows its current column-major output for a 2x5 matrix. Start by locating genericMatrix and any existing tests, then compare their ordering with the example. Done means genericMatrix produces row-major output and the relevant behavior is covered by tests.

Written by the indexing model from the issue text.

Assessment

Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.