Macaulay2 / Macaulay2/M2

What's the point of `isQuotientRing`?

Open
#3,023 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Core
Dominant language
Macaulay2
Stars
435
Forks
297
Avg merge
4d 20h
Merged PRs (30d)
11

Description

https://github.com/Macaulay2/M2/blob/86d6c70f8746e6b13d95c53ad20d880e0d60a8dc/M2/Macaulay2/m2/quotring.m2#L9-L12
It would make sense if, for instance, `isQuotientRing(QQ[x,y]/x)` returned false after flattening the ring, but as it is implemented it seems pointless and counter-intuitive:
```m2
i3 : isQuotientRing (ZZ/3)

o3 = true

i4 : isQuotientRing (ZZ/3[x])

o4 = false
```
I say pointless because it might as well not be a method at all:
```m2
isQuotientRing = R -> class R === QuotientRing
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read M2/Macaulay2/m2/quotring.m2 at lines 9-12 and reproduce the examples for ZZ/3 and ZZ/3[x]. The issue does not specify an agreed behavior or named tests, so first determine the intended definition of isQuotientRing; done requires that behavior to be settled and covered by tests.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.