Re-inventing the wheel for multiprojective space
Nobody has claimed this yet.
- Dominant language
- Macaulay2
- Stars
- 435
- Forks
- 297
- Avg merge
- 4d 20h
- Merged PRs (30d)
- 11
Description
I'd like a multigraded ring for working with a product of projective spaces for some code I'm working on and noticed that it's re-implemented at least four times already in different packages:
* [`CharacteristicClasses::MultiProjCoordRing`](https://faculty.math.illinois.edu/Macaulay2/doc/Macaulay2-1.21/share/doc/Macaulay2/CharacteristicClasses/html/___Multi__Proj__Coord__Ring.html)
* [`CorrespondenceScrolls::productOfProjectiveSpaces`](https://faculty.math.illinois.edu/Macaulay2/doc/Macaulay2-1.21/share/doc/Macaulay2/CorrespondenceScrolls/html/_product__Of__Projective__Spaces.html)
* [`K3Carpets::productOfProjectiveSpaces`](https://faculty.math.illinois.edu/Macaulay2/doc/Macaulay2-1.21/share/doc/Macaulay2/K3Carpets/html/_product__Of__Projective__Spaces.html)
* [`TateOnProducts::productOfProjectiveSpaces`](https://faculty.math.illinois.edu/Macaulay2/doc/Macaulay2-1.21/share/doc/Macaulay2/TateOnProducts/html/_product__Of__Projective__Spaces.html)
This seems like a useful enough construction that perhaps it could be moved to `Core` or some other basic package that these other packages could import.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the four existing implementations: CharacteristicClasses::MultiProjCoordRing and productOfProjectiveSpaces in CorrespondenceScrolls, K3Carpets, and TateOnProducts. Determine whether a shared implementation belongs in Core or another basic package, then verify that the affected packages can import it without changing their behavior.
Written by the indexing model from the issue text.
Assessment
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100