Bug in reducedRowEchelonForm
Nobody has claimed this yet.
- Dominant language
- Macaulay2
- Stars
- 435
- Forks
- 297
- Avg merge
- 4d 20h
- Merged PRs (30d)
- 11
Description
The method `reducedRowEchelonForm` does not put identically zero rows at the bottom (and thus is technically not even in row echelon form, cf. [here](https://en.wikipedia.org/wiki/Row_echelon_form)):
```
i1 : A = matrix{{0_(ZZ/2),0,0},{1,0,1},{0,1,1}}
o1 = | 0 0 0 |
| 1 0 1 |
| 0 1 1 |
ZZ 3 ZZ 3
o1 : Matrix (--) <--- (--)
2 2
i2 : A == reducedRowEchelonForm A
o2 = true
```
Also, it would be nice for `reducedRowEchelonForm` to support more types of rings, e.g. `cyclotomicField`s from the `Cyclotomic` package, or more generally any output of `toField`.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the reducedRowEchelonForm method and reproduce the issue's ZZ/2 example. Verify that identically zero rows are placed at the bottom while preserving the reduced result, then investigate whether support for cyclotomicFields or other toField outputs is in scope.
Written by the indexing model from the issue text.
Assessment
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100