Macaulay2 / Macaulay2/M2

RingMap.cache.DegreeMap

Open
#1,919 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Core
Dominant language
Macaulay2
Stars
435
Forks
297
Avg merge
4d 20h
Merged PRs (30d)
11

Description

It's unfortunate that the degree map of a ring map is stored in its cache table, because it should play a role in determining whether two ring maps are equal. What prevents the degree map from being stored outside the cache table is that it's a function, and there is no way to test whether two functions implement the same degree map. Replacing the function by a matrix over ZZ (or null, for the identity map) would be one way to go, but it would slow things down, possibly a lot, because some degree maps are much more easily implemented as functions (such as appending a 0 to the list of degrees).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the RingMap cache and DegreeMap implementation, then trace how ring-map equality currently uses cached data. Define what representation and equality behavior are required, and assess the performance tradeoffs before identifying the relevant tests or benchmarks to update.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.