Macaulay2 / Macaulay2/M2

OptionalComponentsPresent set to false because of the dependency?

Open
#1,854 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Core
Dominant language
Macaulay2
Stars
435
Forks
297
Avg merge
4d 20h
Merged PRs (30d)
11

Description

Suppose `package1` imports `package2`, and `package2` has optional components.
`OptionalComponentsPresent` is set to false for `package1` even if the optional components for `package2` are present.

I had to work around this in https://github.com/NumericalSchubertCalculus/M2/commit/b436e6ddfeca1d5a2d06392aa36e8a7574099064
by duplicating code from `package2` of @janverschelde .
(The primary reason for this commit is to make `check "package1"` to run checks.)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how package dependencies are processed when `check "package1"` runs, using the `package1`/`package2` example and the linked workaround commit as references. Reproduce the case with `package2`'s optional components present; done means `OptionalComponentsPresent` remains true for `package1` and its checks run without duplicated package code.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
40/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.