Macaulay2 / Macaulay2/M2

Finalization improvements

Open
#1,187 1 comment 0 reactions 2 assignees View on GitHub

@DanGrayson is already working on this.

Since May 22, 2020.

Engine
Dominant language
Macaulay2
Stars
435
Forks
297
Avg merge
4d 20h
Merged PRs (30d)
11

Description

  • MutableEngineObject is not a good name. Change e/hash.hpp to have types EngineObject and EngineObjectNeedingFinalization
  • hash values in these objects will be handled by defining a default computeHashValue, which assigns a serial number.
  • remove the intern_* routines in `e/finalize.{hpp,cpp}

This can be done after the merge of the eigen branch into master.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.