No properly handling ring maps with GaloisFields as coefficient rings.
Open
@zeromath is already working on this.
Since May 23, 2020.
Core
- Dominant language
- Macaulay2
- Stars
- 435
- Forks
- 297
- Avg merge
- 4d 20h
- Merged PRs (30d)
- 11
Description
Here is a small example showing the issue:
i1 : R = GF(4)[x]; S = GF(16)[y]; f = map(S,R,{y})
o3 = map(S,R,{y, a})
o3 : RingMap S <--- R
The generator of the GF(4) in R is not mapped to S properly by the natural inclusion map map(GF(16),GF(4)), it's simply mapped to the generator of GF(16).
In ringmap.m2 there is a chunk of code checking whether the source has coefficientRing being GaloisField, trying to map the PrimitiveElement to the correct place. But it ends up using the naive "mapping to the generator" approach.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.