MacPass / MacPass/MacPass

Remove instant Editable behavior

Open
#47 3 comments 2 reactions 1 assignee View on GitHub

@mstarke is already working on this.

Since Jul 13, 2013.

Dominant language
Objective-C
Stars
6.9k
Forks
469
Avg merge
4d 12h
Merged PRs (30d)
2

Description

Currently the Inspector is instantly editable, this seems risky.

Another approach might be to use a dedicated "edit" button and then enable the editing features. If editing is disabled, all attributes are read only.

I'm not sure which way might be good. But it seems a lot of tools that use display and edit in the same spot have this two mode way. 1Password does it this way, offers an easy "start editing" by double-clicking any entry.
Apple's Contracts uses the same way, by letting entries be viewable and one has to explicitly click "edit" and "done" when one wants to make changes.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.