MacDownApp / MacDownApp/macdown

Replace function is always replacing the current selected text

Open
#707 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Rich Text Format
Stars
9.8k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

The replace function (Edit-Find-Find and Replace...) is always replacing the current selected text, regardless of whether the current select text matches the source text. (Replace All is working as expected.)

It should at least do a "Find" from cursorStart to ensure the selected text matches the source text before replacing it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Edit-Find-Find and Replace... entry point and compare its single-replacement behavior with Replace All, which the report says works correctly. Reproduce the case where the selection does not match the source text, then verify that matching selections still replace and nonmatching selections are left unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
macos, objective-c
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.