MacDownApp / MacDownApp/macdown

Changing CSS to Solarized removes PDF preview margins

Open
#466 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rich Text Format
Stars
9.8k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

View PDF preview from print view, and note the page margins. Change the CSS to solarized dark (may also happen for others), and then repeat the PDF preview. Now the margins have disappeared, and the page looks kinda ugly and unprofessional.

On the left is with default CSS, on the right with solarized dark.
screen shot 2015-10-12 at 15 09 19

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue from the print view by comparing PDF preview margins with default CSS and Solarized Dark. Start by locating the CSS or print-preview entry point used by MacDown; done means the page margins remain present and the preview no longer looks visually degraded after changing themes.

Written by the indexing model from the issue text.

Assessment

Tech stack
css
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.