MacDownApp / MacDownApp/macdown

Graphviz's filled and color attributes doesn't work

Open
#1,138 4 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Rich Text Format
Stars
9.8k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

Like

`digraph {
node [style=filled,color=white];
a -> b
}`

The result is:
![image](https://user-images.githubusercontent.com/33367355/71623818-0998c480-2c1a-11ea-9d8f-47587a4254cb.png)

On viz-js.com , it seems :

![image](https://user-images.githubusercontent.com/33367355/71623859-45338e80-2c1a-11ea-87f7-9de23ed52f3a.png)

I know why!.
The mermaid we use is older version, it's css file 'mermaid.forest.css' override the node's style.

So, If we upgrade the mermeiad, we do not need the mermaid.forest.css file. So it is ok.

Like this:
![image](https://user-images.githubusercontent.com/33367355/71624011-4f09c180-2c1b-11ea-8564-703b504a2ed8.png)

Contributor guide

Open the contributing guide

Research direction

Inspect the Mermaid integration and the mermaid.forest.css file mentioned in the issue, then reproduce the Graphviz example with filled and color attributes. Done means the rendered nodes honor those attributes without the stylesheet overriding them.

Written by the indexing model from the issue text.

Assessment

Tech stack
css
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.