MaartenGr / MaartenGr/BERTopic

Enable additional ruff rules

Open
#2,450 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
7.8k
Forks
920
Avg merge
22h 24m
Merged PRs (30d)
5

Description

I would like to propose enabling additional ruff rules.

There might be performance gains when enabling some of these? E.g.:

- [x] RUF: https://docs.astral.sh/ruff/rules/#ruff-specific-rules-ruf
- [x] PD: https://docs.astral.sh/ruff/rules/#pandas-vet-pd
- [ ] UP: https://docs.astral.sh/ruff/rules/#pyupgrade-up
- [ ] NPY: https://docs.astral.sh/ruff/rules/#numpy-specific-rules-npy

What do you think?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Ruff documentation for the RUF, PD, UP, and NPY rule groups, then locate the repository's Ruff configuration and run its lint checks. Confirm which rules are agreed on and record or resolve the resulting violations; done means the selected rules are enabled without leaving unresolved lint failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.