MaartenGr / MaartenGr/BERTopic
Why use multiple classes for Langchain and OpenAI
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7.8k
- Forks
- 920
- Avg merge
- 22h 24m
- Merged PRs (30d)
- 5
Description
Hi @MaartenGr,
interesting approach to abstracting llm providers - by creating separate classes langchain.py and openai.py
Why have them as 2 separate classes? doesn't langchain cover the openai scenario already?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The question names langchain.py and openai.py. Read both files and compare how the two provider abstractions handle OpenAI; then review the surrounding provider usage to determine whether consolidation is appropriate. No concrete implementation or acceptance criteria are provided, so the desired definition of done is unresolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- ai
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 15/100