MSRevive / MSRevive/MasterSwordRebirth
Find suitable replacement for TerminateThread() Calls.
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 22
- Forks
- 16
- Avg merge
- 5m
- Merged PRs (30d)
- 1
Description
Not sure about how involved this is, goes a bit past my knowledge or experience but...
Microsoft labels this function call as 'dangerous' and only to be used in the most 'extreme' of circumstances.
Searching, it looks like this function is only called in :
client->inputw32.cpp
Doc on item:
https://learn.microsoft.com/en-us/cpp/code-quality/c6258?view=msvc-170
Might be worth the effort to try and refactor to a safer alternative.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in client->inputw32.cpp and review every TerminateThread call alongside Microsoft's C6258 guidance. Identify the safer replacement and its impact on the input-thread behavior; the work is done when the dangerous calls are removed without breaking that behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev, operating-systems
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100