MSRevive / MSRevive/MasterSwordRebirth

Player entity targeted spells don't release pointer for next cast

Open
#359 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
22
Forks
16
Avg merge
5m
Merged PRs (30d)
1

Description

When using rejuvination or ice shield to target a player, attempting to rapidly switch between targets will often cast the spell on the last player hit, regardless of aim.

Reproduction method: Cast ice shield on a player, turn away from player and cast spell again (may require missing any target on next cast). Spell will recast on last hit player instead of defaulting to self. Does not seem to happen for more than 1 cast.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with Ice Shield or Rejuvenation: target a player, turn away, and cast again without a target. Trace the player-targeting and spell-casting entry points to determine why the previous target is reused; done means an untargeted follow-up cast defaults to self rather than the last player.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.