MSRevive / MSRevive/MasterSwordRebirth

Rewrite galat chest

Open
#349 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement 🔧 game med priority
Dominant language
C++
Stars
22
Forks
16
Avg merge
5m
Merged PRs (30d)
1

Description

Currently the galat chest is handled by adding a bunch of items into quest data in the scripts and as which relies on the 255 character array limit. The rewrite into the actual game code would allow us get rid of the silly 255 byte string limit and store it directly into the character file instead of it being a quest.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how the galat chest is assembled from quest data in the scripts and where character files are handled in the game code. Confirm how the current 255-byte string limit affects storage, then define completion as storing the chest directly in the character file rather than as a quest, with the limit removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.