MSRevive / MSRevive/MasterSwordRebirth

Low charge modifier towards damage

Open
#346 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

critical ⚠️ game help wanted
Dominant language
C++
Stars
22
Forks
16
Avg merge
5m
Merged PRs (30d)
1

Description

If you attack too quickly you'll end up doing way less damage then what you should be doing.

Image

it's doing the damage scaling of a partial charge but multiplying by a value less than 0.1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by locating the attack charge and damage-scaling entry point, then compare damage from a quick attack with the intended partial-charge result shown in the report. Done means quick attacks no longer apply an unexpectedly tiny damage multiplier while normal charge scaling remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.