MSRevive / MSRevive/MasterSwordRebirth
entities.cpp and .h cause compile errors in cbase
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 22
- Forks
- 16
- Avg merge
- 5m
- Merged PRs (30d)
- 1
Description
'IScripted': base class undefined - https://github.com/MSRevive/MasterSwordRebirth/blob/ffa2dc04aebd4f470895dbaf91559157a397b655/src/game/server/hl/cbase.h#L621 and https://github.com/MSRevive/MasterSwordRebirth/blob/
'return': cannot convert from 'CScriptedEnt *' to 'IScripted *' - https://github.com/MSRevive/MasterSwordRebirth/blob/ffa2dc04aebd4f470895dbaf91559157a397b655/src/game/server/hl/cbase.h#L624
Probably merged this https://github.com/MSRevive/MasterSwordRebirth/pull/299 a little to soon, but oh well.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting src/game/server/hl/cbase.h around lines 621-624 and the entities.cpp/.h files named in the issue, then reproduce the cbase compile errors. Trace the declarations involved in IScripted and CScriptedEnt, and consider the issue complete when the reported conversions and base-class errors no longer occur in the build.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100