MSRevive / MSRevive/MasterSwordRebirth

Combat music brush entity does not work(msarea_music_dynamic)

Open
#271 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

med priority
Dominant language
C++
Stars
22
Forks
16
Avg merge
5m
Merged PRs (30d)
1

Description

Combat music brush entity does not work for me (msarea_music_dynamic). The global/worldspawn key+value pair also does not work for me. It may set the data somewhere, but it will never play idle or combat music. msarea_music_dynamic will function as a music player, but the intended purpose of setting dynamic music did not work for me.

It should be noted that the addparam/MSscript method of doing combat music works. The way you do it is play music normally, as you would with a msarea_music brush entity. That is your idle music track, and you can use the addparam key+value pair to set individualized mob combat music. (e.g. on a boss monster "params/set_cbm;thebirth.mp3;set_cbml;3:27")

TL;DR
The MSscript dynamic music system works, and the brush entity and/or worldspawn methods do not.

Wiki reference from patchnotes:
https://msrebirth.net/Developer-Knowledge-Articles/Archived-MSC-Patchnotes/2015_FEBa/?h=music#mapper-toys

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked patchnotes section, then search the codebase for msarea_music_dynamic and the worldspawn music key/value handling. Reproduce the issue with a map using the brush and worldspawn methods, comparing them with the working MSscript addparam method. Done means both intended dynamic music methods play idle and combat tracks.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.