MSRevive / MSRevive/MasterSwordRebirth

Fix Player Colormap / Add to Options Menu

Open
#238 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement 🔧 low priority
Dominant language
C++
Stars
22
Forks
16
Avg merge
5m
Merged PRs (30d)
1

Description

By default, our config.cfg has entries for player color-remapping. These are not used in-game for player model rendering it appears, and the sliders to set these values have been removed from the options menu. From looking through studiomodelrenderer.cpp, I believe that the function that enables color-remapping has been removed or never added to our codebase. The default HLSDK found in github contains code from TFC that enables the original support for this.

Valve Goldsrc SDK:
https://github.com/ValveSoftware/halflife/blob/c7240b965743a53a29491dd49320c88eecf6257b/cl_dll/StudioModelRenderer.cpp#L1106

Default config.cfg values found in MSR:
bottomcolor "6"
topcolor "30"

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in studiomodelrenderer.cpp and compare the color-remapping support with the referenced Valve Goldsrc SDK implementation. Then inspect the options menu and config.cfg entries for bottomcolor and topcolor. Done means player model color-remapping works in-game and controls for these values are available in the options menu.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.