MSRevive / MSRevive/MasterSwordRebirth

Refactor item handling.

Open
#140 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

critical ⚠️ enhancement 🔧 game
Dominant language
C++
Stars
22
Forks
16
Avg merge
5m
Merged PRs (30d)
1

Description

Currently all items in your inventory is spawned in the world at 0,0,0 which contributes to the entity limit. We should find a way to only spawn the items that are being used and make the items in the inventory just be data instead of being spawned entities, this would probably allow players to have a lot more items in their inventory and save up on used entity limit. The galat chest items are not handled this way though.

We should also investigate a way to convert string names of items to some kind of short hand like an ID and way to convert them back to script name so players won't loose any items by us changing the script name.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by tracing how inventory items and galat chest items are spawned, then review how item script names are stored and converted. Done means inventory items remain data rather than spawned entities, while item names can be safely converted and restored without loss.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.