MSRevive / MSRevive/MSCScripts

Weapons need crit stuffs

Open
#273 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

critical ⚠️ enhancement
Dominant language
AngelScript
Stars
4
Forks
12
Avg merge
14h 8m
Merged PRs (30d)
5

Description

  • reg.attack.critmulti - The critical multiplier, float.
  • reg.attack.critthreshold - The crit hit threshold, float.
  • weapon_crit_success - Script event called on weapon when a crit was successful.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the weapon implementation and existing registry fields or script events related to attacks. Trace how weapon critical hits are handled, then add the two named attack values and the weapon_crit_success event; done means scripts can access both values and receive the event after a successful critical hit.

Written by the indexing model from the issue text.

Assessment

Domain
game-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
63/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.