MLMI2-CSSI / MLMI2-CSSI/foundry

Convenience find_by methods

Open
#402 0 comments 0 reactions 1 assignee View on GitHub

@blue442 is already working on this.

Since Nov 21, 2023.

enhancement
Dominant language
Python
Stars
88
Forks
17
PR merge metrics
No merged PRs in 30d

Description

As a foundry dataset user I want to easily be able to find a dataset by DOI or by source_id so I can go directly to my dataset of interest

Description

Add find_by_doi and find_by_dataset to the Foundry class.

These methods return a single Dataset instance

Assumption

  1. if the source ID or DOI don't exist, throw an informative exception

Acceptance Criteria

f = Foundry()
ds = f.find_by_doi("DOI12/344")

ds2 = f.find_by_source_id("1233423")

f.find_by_source_id("doesnotexist")
f.find_by_doi("doesnotexist")

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.