MLMI2-CSSI / MLMI2-CSSI/foundry

Investigate HDF5 data location bug

Open
#391 2 comments 0 reactions 1 assignee View on GitHub

@blue442 is already working on this.

Since Aug 22, 2023.

bug
Dominant language
Python
Stars
88
Forks
17
PR merge metrics
No merged PRs in 30d

Description

As a Data Consumer, I want to ensure the data files for the datasets I download all go to the same general location.

Jingrui has found a bug where for some reason extra copies of HDF5 files only are downloaded to ./data in addition to their proper locations. This isn't a game-breaking bug, but is untidy and should be resolved.

Track down the bug and resolve it such that all data go to the appropriate folders in the format /data/dataset_name_vx.x/

From Jingrui: "Here is one about downloading extra instance of data files that I just reported to Ben and I'd share the details here.
When downloading a dataset, Foundry should create directory and save the data at ./data/dataset_name_vx.x/ . While for the h5 datasets, mostly published by me and there's also one published by someone else, extra copies of the files are saved at ./data/ .
All the tabular datasets I tested are fine."

Image

Acceptance criteria

  1. The bug has been resolved and the data are only downloaded to the appropriate folder for that dataset, as described above
  2. The fix is released
  3. Jingrui has been alerted to the fix

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.