Avoid code repetition in the Problem Definition module
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 123
- Forks
- 22
- PR merge metrics
- No merged PRs in 30d
Description
We should review the code repetition in the ProblemDefinition subclasses and avoid it, moving the code to the parent class if it is necessary, the following methods need special attention:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in cardea/problem_definition/definition.py, focusing on ProblemDefinition.generate_target_label(...) and generate_cutoff_times(...). Compare those methods across the ProblemDefinition subclasses to identify repeated behavior and determine what belongs in the parent class. Done means the repetition is reduced without changing the subclasses' behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100