Complete unfinished vizapp functionality
Open
A pull request for this has already been merged.
- #515 by @wbenoit26 — merged
plotting
- Dominant language
- Python
- Stars
- 18
- Forks
- 28
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 7
Description
Several vizapp components are incomplete.
- SensitiveVolumePlot.update() updates self.background but does not recompute or re-render the SV curves. Requires reworking make_plot() to use ColumnDataSource so update() can push new data without rebuilding the plot.
- DataManager.update_vetos() applies vetos to the background but always returns the foreground unmodified.
- DataManager.calculate_veto_masks() iterates over self.veto_options which is never initialized.
- Mass and SNR sliders in DistributionPlot are initialized with hardcoded 0–100 range regardless of the actual data.
- SNR ratio per event should be added to DataManager.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the vizapp implementations of SensitiveVolumePlot.update()/make_plot(), DataManager.update_vetos()/calculate_veto_masks(), and DistributionPlot's Mass and SNR sliders. Review how these components currently handle background, foreground, veto options, and data ranges. Done means all listed behaviors work, including the per-event SNR ratio, with the existing visualization updating correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data-visualization
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100