ML4GW / ML4GW/DeepClean

How to name online framefiles when there is non-integer aggregation latency?

Open
#40 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
10
Forks
6
PR merge metrics
No merged PRs in 30d

Description

I faced this issue with the prototype model I have been using that if we are going with non-integer aggregation latency, the frame file will have to be named decimal points in the GPS times.

For example, the frame that comes from a kernel ending at 1230000000, the 1s frame that we write after allowing an aggregation latency of 0.25, will be named (under the standard naming strategy followed in LIGO) as something like H-H1_HOFT-1229999998.75-1.gwf

which follows H-H1_HOFT-{start}-{duration}.gwf

Earlier it appeared ugly to me and I kept the timestamps to integers as if we did not apply an aggregation latency while it was actually applied (and terribly forgot about it :( ). This is what eventually led to the inconsistencies in the PE tests as the injected signals were not found at the times they were expected to be.

What is the solution in the long term?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the prototype model's frame-writing path and the PE tests that exposed the timestamp inconsistency. Define and document a long-term naming convention for non-integer aggregation latency, then verify that injected signals are found at their expected times under that convention.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-engineering
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.