MIT-LCP / MIT-LCP/wfdb-python

Original WFDB C package notes and nuances

Open
#7 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
853
Forks
322
PR merge metrics
No merged PRs in 30d

Description

WFDB Invalid sample limitation

Currently the wfdb library does not account for >16bit formats and hence uses the value -32768 as nan.

For this python package for rdsamp physical==0, I have currently decided to set empty multi-segment channels (with stacksegments==1) to -2^31. We can revise this later if needed and see what happens with the next version of the wfdb library. In addition, all format samples will be stored (with physical==0) as they are with no mapping.

For rdsamp for option physical==1, 2^(fmt-1) will be interpreted as nans.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the rdsamp handling for physical==0 and physical==1, including empty multi-segment channels with stacksegments==1. Compare the package behavior with the original WFDB C package's invalid-sample conventions. Done means the intended handling of -2^31, 2^(fmt-1), and unmapped format samples is clearly recorded or resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
documentation
Issue type
Documentation
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.