MIT-LCP / MIT-LCP/wfdb-python

the valid range of A(annotation type value)

Open
#533 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
853
Forks
322
PR merge metrics
No merged PRs in 30d

Description

Why should the value of A be restricted to between 1 and 49? The values greater than 58 are pre-defined as (skip-59, num-60, sub-61, chan-62, aux-63),Can I define the values between 49 and 58(bound included)? and lift this restriction?

https://github.com/MIT-LCP/wfdb-python/blob/main/wfdb/io/annotation.py#L563


        elif field == "label_store":
            if min(item) < 1 or max(item) > 49:
                raise ValueError(
                    "The label_store values must be between 1 and 49"
                )

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in wfdb/io/annotation.py around the label_store validation at line 563, then review how annotation values above 49 are represented, including the predefined values 59–63. Confirm whether values 49–58 are valid in the WFDB format and update the validation behavior accordingly; done means the restriction matches the format specification.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.