MIT-LCP / MIT-LCP/wfdb-python

wrsamp wrong output *.dat filename

Open
#153 1 comment 0 reactions 1 assignee View on GitHub

@Lucas-Mc is already working on this.

Since Apr 30, 2020.

Dominant language
Jupyter Notebook
Stars
853
Forks
322
PR merge metrics
No merged PRs in 30d

Description

I follow demo #10 to clone from an existing record with this code.

rec = wfdb.rdrecord('sample-data/100', physical=False)
rec.record_name = '100_cloned'
rec.wrsamp()

2 files were created

100.dat
100_cloned.hea

May I know why the *.dat file was not rename to 100_cloned.dat? Is this a bug or by design?

If it's by design, I think there is a flaw. Suppose I clone a record, modify the waveform, and save to the same folder, then the original 100.dat will be overwritten! Isn't that a bad thing? Please advice

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.