MIT-LCP / MIT-LCP/physionet

ATM page needs more semantic markup

Open
#8 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

accessibility
Dominant language
Python
Stars
82
Forks
21
Avg merge
35m
Merged PRs (30d)
1

Description

The output here needs a bit more semantic markup:

  • include role="main" or main element wrapping the entire main page content;
  • introduce the main section with an h1 which wraps the relevant title of the page (ATM Output for xxx) or some such;
  • There is an h1 which reads: "No annotations!" This is the only heading on the page. This should be demoted to h2, or perhaps lower if it is contained within another subsection.
  • There is bold text which reads: "navigation" just before some toolbar buttons labeled like "<<", "<", "*", ">", ">>", etc. Use a heading tag instead of simply marking it as bold text.
  • There is text which reads: "current observation window -- click on either side to move it". Mark this up as a heading.
  • Within the observation window, somehow separate the various items either via list markup, heading markup, wrap each distinct item in a container like div with role="article", or use role="region" and then add a label to each via aria-label.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the implementation of the ATM output page and inspect how its headings, toolbar, observation window, and page container are currently rendered. Use the issue’s semantic-markup requirements as the checklist, then verify that the page has a meaningful heading hierarchy and identifiable content regions with an accessibility inspection.

Written by the indexing model from the issue text.

Assessment

Tech stack
html
Domain
accessibility, frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.