MIT-LCP / MIT-LCP/physionet

parser in 10.5.24 wrsamp is broken

Open
#71 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
82
Forks
21
Avg merge
35m
Merged PRs (30d)
1

Description

Just so that someone else who has a 10.5.24 (actually, I suspect .23 and later) binary doesn't spend two weeks pulling their hair out like I just did...

The parser in 10.5.24 wrsamp incorrectly tokenizes data lines that contain square-bracket-enclosed date stamps. Because it treats a space character as a valid token delimiter, and doesn't recognize square brackets as "quoting" tokens that contain delimiters, wrsamp breaks the date stamp into two separate tokens, causing the column-indexing for selecting data columns to be off-by-one.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the wrsamp parser entry point and reproduce the failure with a data line containing a square-bracket-enclosed date stamp. Trace how spaces and brackets are tokenized, then verify that the date remains one token and that selecting data columns no longer shifts the column index.

Written by the indexing model from the issue text.

Assessment

Domain
cli, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.