MIT-LCP / MIT-LCP/physionet

xform upsampling drops 1st input sample

Open
#50 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
82
Forks
21
Avg merge
35m
Merged PRs (30d)
1

Description

When upsampling with factor two, the 1st input sample is neglected and the output starts from the 2nd input sample. After that the output is as should.

Can be repeated with the headers and MATLAB script found in the attached zip file.

upsample

test.zip

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the headers and MATLAB reproduction script in the attached test.zip, then inspect the xform upsampling path for factor two. Compare its output with the first input sample included, and consider the issue done when the output retains that sample and subsequent samples remain correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
matlab
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.