GainQRSdetect hardcoded to 2000 leading to errors
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 82
- Forks
- 21
- Avg merge
- 35m
- Merged PRs (30d)
- 1
Description
Hi,
ConvertRawDataToRRIntervals seemed to not process some files and I finally found that it was because of the line 48 that hardcode amplifies the signal by 2000 before the signal is processed by wqrsm_fast where the gain default is 200 (line 80: WFDB_DEFGAIN = 200.0). When I remove the gain of 2000 in ConvertRawDataToRRIntervals, I don't get the error.
Is there a strong reason why I should keep the hardcoding for the gain of 2000 in ConvertRawDataToRRIntervals or is it an error?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with ConvertRawDataToRRIntervals at the reported line 48 and compare its hardcoded gain of 2000 with wqrsm_fast and WFDB_DEFGAIN at line 80. Reproduce the files that fail, determine which gain is expected for the input signal, and confirm that RR-interval conversion completes without errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100