MISP / MISP/misp-objects

Ambiguities regarding registry-key object

Open
#361 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
110
Forks
139
Avg merge
12h 28m
Merged PRs (30d)
3

Description

From the description of the registry-key object, it's not really clear, what kind of information to put where. The object states in the description, that it includes a key and a value, however, registry data needs three things:

  • key (the path, e.g. HKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\Run)
  • value (the value set, in this case, e.g. Windows Update Host)
  • data (the data itself, in this case a path to a file, e.g. C:\Users\User\AppData\Roaming\Microsoft\Update\Host.exe)

The object templates just defines key, data and a data-type (but not value). Probably the value is seen as part of the key here, but this is not mentioned in the description and in the typical microsoft terminology there is a difference between key and value.

As a JSON representation the difference would be like this:

MISP registry-key object

{
  "key": "data"
}

MS registry terminology

{
  "key": {
    "value": "data"
  }
}

Going to add a PR which changes the description of key, but wanted to create this issue for a potential discussion first.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the registry-key object description and template, then compare their key, data, and data-type fields with the Microsoft registry terminology and examples in the issue. Done means the documentation explicitly explains how the registry key, value, and data are represented and removes the ambiguity about whether value is part of key.

Written by the indexing model from the issue text.

Assessment

Tech stack
json
Domain
documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.