chardet version mismatch 3.0.4 / 4.0.0
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 377
- Forks
- 280
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 10
Description
misp-modules has a versioned dependency on chardet 3.0.4 https://github.com/MISP/misp-modules/blob/main/REQUIREMENTS#L30
faup added chardet as a unversioned dependency stricaud/faup@b5c82fb a couple of daus ago, so it defaults to 4.0.0.
A quick read-through of https://github.com/chardet/chardet/releases/tag/4.0.0 indicated that there were no API changes, so misp-modules could in theory swap to 4.0.0?
Example of where this breaks: https://github.com/coolacid/docker-misp/issues/121
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with REQUIREMENTS#L30 and compare its chardet constraint with the unversioned dependency introduced by the referenced faup commit. Review the chardet 4.0.0 release notes, then use the linked docker-misp example to confirm the conflict; done means the dependency requirements no longer produce the reported break.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100