MISP / MISP/misp-modules

Potential bug in expansion "yara_query"

Open
#442 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

potential-bug
Dominant language
Python
Stars
377
Forks
280
Avg merge
2d 2h
Merged PRs (30d)
10

Description

ERROR:misp-modules:Something went wrong:
Traceback (most recent call last):
  File "/home/circl/.local/lib/python3.8/site-packages/misp_modules/__init__.py", line 201, in post
    response = yield tornado.gen.with_timeout(timeout, self.run_request(jsonpayload))
  File "/usr/local/lib/python3.8/dist-packages/tornado/gen.py", line 735, in run
    value = future.result()
  File "/usr/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/circl/.local/lib/python3.8/site-packages/misp_modules/__init__.py", line 189, in run_request
    response = mhandlers[x['module']].handler(q=jsonpayload)
  File "modules/expansion/yara_query.py", line 35, in handler
    condition, required_module = get_hash_condition(attribute_type, value)
  File "modules/expansion/yara_query.py", line 18, in get_hash_condition
    hashvalue = hashvalue.lower()

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with modules/expansion/yara_query.py, especially get_hash_condition at line 18 and handler at line 35, then trace the input that reaches hashvalue.lower(). Reproduce the reported traceback and verify that the yara_query expansion handles the failing input without raising the same error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.